Refactor amp bento prelim #37181
Refactor amp bento prelim #37181
Conversation
kvchari
requested review from
alanorozco and
samouri
and removed request for
alanorozco
|
Can you provide a description? |
kvchari
force-pushed
the
refactor-amp-bento-prelim
branch
from
5b25bf0
to
f592e9b
Compare
| @@ -3,17 +3,11 @@ | |||
| <head> | |||
| <script src="https://cdn.ampproject.org/bento.js"></script> | |||
| <!-- These styles prevent Cumulative Layout Shift on the unupgraded custom element --> | |||
| <style> | |||
There was a problem hiding this comment.
I'm missing context here, why are these no longer necessary?
There was a problem hiding this comment.
we'd decided to recommend consumers ensure that components avoided layout shift by link to our stylesheets rather than copy/paste these styles, but these fixtures were never updated to reflect that. (the link rel is added on line 10)
| @@ -6,11 +6,6 @@ | |||
| async | |||
| src="https://cdn.ampproject.org/v0/bento-lightbox-1.0.js" | |||
| ></script> | |||
| <link | |||
There was a problem hiding this comment.
Same here, why is this ok to remove?
There was a problem hiding this comment.
hmm didn't mean to remove this, i can revert
| @@ -0,0 +1,3 @@ | |||
| import {PreactBaseElement} from './base-element'; | |||
|
|
|||
| export class AmpPreactBaseElement extends PreactBaseElement {} | |||
There was a problem hiding this comment.
nit: not necessary for this PR in particular, but the architecture we are deciding on right now should be written up in a jsdoc
kvchari
force-pushed
the
refactor-amp-bento-prelim
branch
from
f592e9b
to
fdc57e7
Compare
kvchari
force-pushed
the
refactor-amp-bento-prelim
branch
from
fdc57e7
to
728ab3a
Compare
|
closing in favor of: #37309 |
partial #36950