♻️ Migrate most of #core to pass TS typechecking

[rcebulko]

Migrates most of the files under src/core from Closure type-checking to Typescript. Closure will no longer pass type-checking on many (most?) of these files. As a result, all Closure-based type-checking will stop passing (and so has been silenced in check-types.js). Later PRs will handle cleaning out legacy type-checking code.

Two #core directories are excluded: context and assert. context is intricate and isolated, so it can be migrated independently while this PR unblocks progress elsewhere in the repo. assert will be more involved because of differences in how CC and TS handle assertion annotations, so its type signatures are stubbed in this PR to be addressed in a later PR.

Some "globals" we access through the window object, which we rely on for some polyfills and testing scenarios. Because TS doesn't expect them to be on the window, there are corresponding TS definition files .d.ts which add these properties to the Window interface. Anything in a .d.ts file is TS-only logic that need to live outside of existing JS annotations. Mostly, they replace existing .extern.js files.

Files ending in .shame.d.ts contain "band-aids", such as type stubs, that allow type-checking to pass. One example is assert.shame.d.ts, which tells tsc to skip type-checking #core/assert for now and instead provides the type signatures it should expect.

[samouri]

Read through the first half. Will finish reviewing tomorrow morning. Looks great ⭐

[lgtm-com]

This pull request introduces 15 alerts when merging 80a13bb into 3e8072d - view on LGTM.com

new alerts:

• 15 for Ineffective parameter type

[lgtm-com]

This pull request introduces 7 alerts when merging 06e7268 into 6268ef3 - view on LGTM.com

new alerts:

• 7 for Ineffective parameter type

[amp-owners-bot]

Hey @jridgewell! These files were changed:

src/core/3p-frame-messaging.js
src/core/amp-config.d.ts
src/core/assert.shame.d.ts
src/core/assert/index.js
src/core/constants/action-constants.js
src/core/constants/async-input.d.ts
src/core/constants/async-input.js
src/core/constants/loading-instructions.js
src/core/data-structures/curve.js
src/core/data-structures/dom-based-weakref.js
src/core/data-structures/finite-state-machine.js
src/core/data-structures/lru-cache.js
+84 more

[rcebulko]

@samouri bumping this

[samouri]

Do you know what all of the bundle size changes are from?

[samouri]

Awesome work like usual

[samouri]

We cannot enforce this guarantee unless we write a custom script via the new TS API.
That said, I don't think fields get dangerously obfuscated like they did with CC... so this is not really an issue.

cc @jridgewell