📖 Style bento sidebar hero example #36993
Conversation
sebastianbenz
force-pushed
the
bento-example-fixes
branch
from
68ed25b
to
915ade9
Compare
|
Hey @westonruter, @ediamin! These files were changed: |
sebastianbenz
force-pushed
the
bento-example-fixes
branch
2 times, most recently
from
8299212
to
c6292a4
Compare
sebastianbenz
force-pushed
the
bento-example-fixes
branch
from
c6292a4
to
26cbf8d
Compare
There was a problem hiding this comment.
Approved if you do some minor changes: no extra <head>, compress with SVGOMG and prettier-format
|
Also, I think we should use |
| </bento-sidebar> | ||
|
|
||
| <script> | ||
| (async () => { |
There was a problem hiding this comment.
Nit: Formatting is a bit strange here.
There was a problem hiding this comment.
fixed by fixing html syntax error
| <title>bento-sidebar</title> | ||
|
|
||
| <head> | ||
| <script src="https://cdn.ampproject.org/bento.js"></script> |
There was a problem hiding this comment.
Intentionally dropping the module/nomodule pattern here?
There was a problem hiding this comment.
cf. #36992 where it's now:
<script type="module" src="https://cdn.ampproject.org/bento.mjs" crossorigin="anonymous"></script>
<script nomodule src="https://cdn.ampproject.org/bento.js" crossorigin="anonymous"></script>
<script type="module" src="https://cdn.ampproject.org/v0/bento-sidebar-1.0.mjs" crossorigin="anonymous"></script>
<script nomodule src="https://cdn.ampproject.org/v0/bento-sidebar-1.0.js" crossorigin="anonymous"></script>
<link rel="stylesheet" href="https://cdn.ampproject.org/v0/bento-sidebar-1.0.css" crossorigin="anonymous">There was a problem hiding this comment.
For my own clarity, does this mean all these examples will use the pattern listed here automatically by some means or the example here should be updated with this syntax?
There was a problem hiding this comment.
Updated. Examples are not updated automatically, and most hero examples still use the the old pattern. We need a Bento Optimizer...
| } | ||
|
|
||
| h2 { | ||
| font-family: 'Inter', sans-serif; |
There was a problem hiding this comment.
Inter doesn't appear defined in this stylesheet or elsewhere on the document.
* removed duplicate tag resulting in prettier not formatting * use module version * removed unavailable font style
No description provided.