Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ amp-story-shopping-config data json handle get and set config data #36757

Merged
merged 57 commits into from
Nov 18, 2021
Merged

✨ amp-story-shopping-config data json handle get and set config data #36757

merged 57 commits into from
Nov 18, 2021

Commits on Nov 3, 2021

  1. Added examples for inline and remote config loading of json files.

    @jshamble
    jshamble committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    f34a46c View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. finished tests for shopping config

    @jshamble
    jshamble committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    087b53f View commit details
    Browse the repository at this point in the history

  2. removed unnescessary function call

    @jshamble
    jshamble committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    e490dad View commit details
    Browse the repository at this point in the history

  3. fixed merge conflict dleeting base shopping file

    @jshamble
    jshamble committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    8e0502f View commit details
    Browse the repository at this point in the history

  4. removed chai import

    @jshamble
    jshamble committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    593250b View commit details
    Browse the repository at this point in the history

  5. removed unnesc assignment

    @jshamble
    jshamble committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    03879e9 View commit details
    Browse the repository at this point in the history

  6. fixed prettier lint warnings

    @jshamble
    jshamble committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    aa5eb26 View commit details
    Browse the repository at this point in the history

  7. added dependencies for store service

    @jshamble
    jshamble committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    2ec626a View commit details
    Browse the repository at this point in the history

  8. cleanup up code and tests to optmize code flow

    @jshamble
    jshamble committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    87835e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. cleaned up config files and test files

    @jshamble
    jshamble committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    5328ecd View commit details
    Browse the repository at this point in the history

  2. added more refactoring of shopping story

    @jshamble
    jshamble committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    4993c22 View commit details
    Browse the repository at this point in the history

  3. Updated test code with new tag id

    @jshamble
    jshamble committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    dcd51d4 View commit details
    Browse the repository at this point in the history

  4. fixed formatting of remote file

    @jshamble
    jshamble committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    58aa953 View commit details
    Browse the repository at this point in the history

  5. added remote config fiel formatting fix

    @jshamble
    jshamble committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    dbef7ff View commit details
    Browse the repository at this point in the history

  6. added visual diff test

    @jshamble
    jshamble committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    5a67a03 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. updated visual diff test

    @jshamble
    jshamble committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    e711b93 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. updated unit tests to use public facing apis, removed dead code

    @jshamble
    jshamble committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    fed6aab View commit details
    Browse the repository at this point in the history

  2. updated unit tests to use public facing apis, removed dead code

    @jshamble
    jshamble committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    c4baea7 View commit details
    Browse the repository at this point in the history

  3. updated unit tests to use public facing apis, removed dead code

    @jshamble
    jshamble committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    8e0c94b View commit details
    Browse the repository at this point in the history

  4. added page id

    @jshamble
    jshamble committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    33d72d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. added load config impl (both solutions: one exposed export public met… 

    …hod, and another private moethd that gets called, fallback to the exported loadconfigimpl if suggested by the review team)
    @jshamble
    jshamble committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    35bacc3 View commit details
    Browse the repository at this point in the history

  2. removed export ()may need to put back if want to use public facing apit

    @jshamble
    jshamble committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    f7627d4 View commit details
    Browse the repository at this point in the history

  3. modified laodconfig to handle 404 errors

    @jshamble
    jshamble committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    97f38e0 View commit details
    Browse the repository at this point in the history

  4. removed unused var

    @jshamble
    jshamble committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    d555d92 View commit details
    Browse the repository at this point in the history

  5. added dependency for request service

    @jshamble
    jshamble committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    6805ccb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into shopDataJsonHandle

    @jshamble
    jshamble committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    606f109 View commit details
    Browse the repository at this point in the history

  7. added a few recotoring shareconfig menthod

    @jshamble
    jshamble committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    1508aa2 View commit details
    Browse the repository at this point in the history

  8. refactored code to use new request service.

    @jshamble
    jshamble committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    172c6a7 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into shopDataJsonHandle

    @jshamble
    jshamble committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    194effe View commit details
    Browse the repository at this point in the history

  10. removed unused allow list entry

    @jshamble
    jshamble committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    72e64a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. added buidlcallback resolve

    @jshamble
    jshamble committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    b8bf02a View commit details
    Browse the repository at this point in the history

  2. added implicit return

    @jshamble
    jshamble committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    c0278c6 View commit details
    Browse the repository at this point in the history

  3. added in code refactos

    @jshamble
    jshamble committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    988ad88 View commit details
    Browse the repository at this point in the history

  4. updated shoo[[ing state to shopping data

    @jshamble
    jshamble committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    4c6283f View commit details
    Browse the repository at this point in the history

  5. removed promise.resolve

    @jshamble
    jshamble committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    e2284fc View commit details
    Browse the repository at this point in the history

  6. recatored shopping and shared config unit test code

    @jshamble
    jshamble committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    0821aba View commit details
    Browse the repository at this point in the history

  7. added in config refactor logic

    @jshamble
    jshamble committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    152d97f View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. streamlined commens and code

    @jshamble
    jshamble committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    0ba6f8c View commit details
    Browse the repository at this point in the history

  2. fixed comment for circleci

    @jshamble
    jshamble committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    0120f15 View commit details
    Browse the repository at this point in the history

  3. optmized code and unit tests

    @jshamble
    jshamble committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    517e53d View commit details
    Browse the repository at this point in the history

  4. added shared config code

    @jshamble
    jshamble committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    6371fd2 View commit details
    Browse the repository at this point in the history

  5. refactored dead code

    @jshamble
    jshamble committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    6a75291 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. added typedefs

    @jshamble
    jshamble committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    af5fdf4 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. added in refactor of social share widget

    @jshamble
    jshamble committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    cf5d899 View commit details
    Browse the repository at this point in the history

  2. added shopping story test features

    @jshamble
    jshamble committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    3e0c132 View commit details
    Browse the repository at this point in the history

  3. removed unnneded export

    @jshamble
    jshamble committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    0599a2d View commit details
    Browse the repository at this point in the history

  4. udpated product images array

    @jshamble
    jshamble committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    e0bb71b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into shopDataJsonHandle

    @jshamble
    jshamble authored Nov 16, 2021
    Configuration menu
    Copy the full SHA
    fbf7464 View commit details
    Browse the repository at this point in the history

  6. removed trailign whitespace

    @jshamble
    jshamble committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    f53685c View commit details
    Browse the repository at this point in the history

  7. removed unused vars

    @jshamble
    jshamble committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    fe86615 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. removed unused config for now

    @jshamble
    jshamble committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    0184f18 View commit details
    Browse the repository at this point in the history

  2. added back in dev asserts

    @jshamble
    jshamble committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    fafa4a9 View commit details
    Browse the repository at this point in the history

  3. code compactification

    @jshamble
    jshamble committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    d70055e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into shopDataJsonHandle

    @jshamble
    jshamble committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    732f9ab View commit details
    Browse the repository at this point in the history

  5. stripped dev assert

    @jshamble
    jshamble committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    fde3e0d View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. fixed social share config

    @jshamble
    jshamble committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    793ccfd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into shopDataJsonHandle

    @jshamble
    jshamble committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    d86af91 View commit details
    Browse the repository at this point in the history