Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel-plugins: remove simple-array-destructuring #35695

Merged
merged 1 commit into from
Aug 17, 2021
Merged

babel-plugins: remove simple-array-destructuring #35695

merged 1 commit into from
Aug 17, 2021

Conversation

samouri
Copy link
Member

@samouri samouri commented Aug 16, 2021

summary
Partial for #35694

@samouri samouri marked this pull request as ready for review August 16, 2021 22:08
@amp-owners-bot
Copy link

Hey @erwinmombay, @jridgewell! These files were changed:

build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/index.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep-array/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep-array/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/param/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/param/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/output.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/variable-declarations/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/variable-declarations/options.json
+2 more

@samouri samouri self-assigned this Aug 16, 2021
@samouri samouri requested review from jridgewell and rcebulko and removed request for danielrozenberg August 16, 2021 22:08
@samouri samouri mentioned this pull request Aug 16, 2021
Open
5 tasks
@samouri samouri merged commit 194d47d into ampproject:main Aug 17, 2021
@samouri samouri deleted the shinythings branch August 17, 2021 02:13
caroqliu pushed a commit to caroqliu/amphtml that referenced this pull request Aug 17, 2021
@samouri @caroqliu
babel-plugins: remove simple-array-destructuring (ampproject#35695)
e8f67d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@rcebulko rcebulko Awaiting requested review from rcebulko

Assignees

@samouri samouri

Labels
PR use: In Beta / Experimental PR use: In LTS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samouri @jridgewell @ampprojectbot