Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-fit-text: fix cls by hiding until font size calculation #35105

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

samouri
Copy link
Member

@samouri samouri commented Jul 1, 2021

summary

This PR hides amp-fit-text until font size calculation is complete.
For our example doc at examples/amp-fit-text.amp.html:

  • before: 0.055 CLS
  • after: 0.000 CLS

cc @ampproject/wg-performance

Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants