-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Positioning for amp-story-desktop-one-panel
page elements
#34824
Merged
processprocess
merged 16 commits into
ampproject:main
from
processprocess:one-panel-desktop
Jun 17, 2021
Merged
✨ Positioning for amp-story-desktop-one-panel
page elements
#34824
processprocess
merged 16 commits into
ampproject:main
from
processprocess:one-panel-desktop
Jun 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @gmajoulet, @newmuis! These files were changed:
|
gmajoulet
reviewed
Jun 10, 2021
gmajoulet
approved these changes
Jun 11, 2021
gmajoulet
reviewed
Jun 11, 2021
gmajoulet
reviewed
Jun 15, 2021
gmajoulet
reviewed
Jun 15, 2021
gmajoulet
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context / Fixes #34761
Sizing for page elements.
Visual tests for breakpoints.