Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚮 [Story bookend] Remove bookend extended code #34343

Merged
merged 26 commits into from
May 17, 2021
Merged

🚮 [Story bookend] Remove bookend extended code #34343

merged 26 commits into from
May 17, 2021

Commits on May 11, 2021

  1. Started removing bookend

    @mszylkowski
    mszylkowski committed May 11, 2021
    Configuration menu
    Copy the full SHA
    c5d32ce View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Finished removing bookend from files

    @mszylkowski
    mszylkowski committed May 12, 2021
    Configuration menu
    Copy the full SHA
    7256671 View commit details
    Browse the repository at this point in the history

  2. Fixed linting

    @mszylkowski
    mszylkowski committed May 12, 2021
    Configuration menu
    Copy the full SHA
    b663d6c View commit details
    Browse the repository at this point in the history

  3. Updated validation tests

    @mszylkowski
    mszylkowski committed May 12, 2021
    Configuration menu
    Copy the full SHA
    a82c2e6 View commit details
    Browse the repository at this point in the history

  4. Updated validation tests 2

    @mszylkowski
    mszylkowski committed May 12, 2021
    Configuration menu
    Copy the full SHA
    a082337 View commit details
    Browse the repository at this point in the history

  5. Removed bookend strings

    @mszylkowski
    mszylkowski committed May 12, 2021
    Configuration menu
    Copy the full SHA
    eab9491 View commit details
    Browse the repository at this point in the history

  6. Disabled bookend and related tests

    @mszylkowski
    mszylkowski committed May 12, 2021
    Configuration menu
    Copy the full SHA
    48d043f View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Removed checks to bookend

    @mszylkowski
    mszylkowski committed May 13, 2021
    Configuration menu
    Copy the full SHA
    cb8e857 View commit details
    Browse the repository at this point in the history

  2. Linted

    @mszylkowski
    mszylkowski committed May 13, 2021
    Configuration menu
    Copy the full SHA
    6d261ce View commit details
    Browse the repository at this point in the history

  3. Made bookend an alias of social-share

    @mszylkowski
    mszylkowski committed May 13, 2021
    Configuration menu
    Copy the full SHA
    39b6c7f View commit details
    Browse the repository at this point in the history

  4. Removed bookend test since it's not showing

    @mszylkowski
    mszylkowski committed May 13, 2021
    Configuration menu
    Copy the full SHA
    8beae56 View commit details
    Browse the repository at this point in the history

  5. Removed bookend tests

    @mszylkowski
    mszylkowski committed May 13, 2021
    Configuration menu
    Copy the full SHA
    ecf87d5 View commit details
    Browse the repository at this point in the history

  6. Fixed linting

    @mszylkowski
    mszylkowski committed May 13, 2021
    Configuration menu
    Copy the full SHA
    d0d3033 View commit details
    Browse the repository at this point in the history

  7. Cleanup

    @mszylkowski
    mszylkowski committed May 13, 2021
    Configuration menu
    Copy the full SHA
    38a400d View commit details
    Browse the repository at this point in the history

  8. Fixed linting again

    @mszylkowski
    mszylkowski committed May 13, 2021
    Configuration menu
    Copy the full SHA
    0a5f10e View commit details
    Browse the repository at this point in the history

  9. Removed visual tests

    @mszylkowski
    mszylkowski committed May 13, 2021
    Configuration menu
    Copy the full SHA
    1fd462d View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Fixed test

    @mszylkowski
    mszylkowski committed May 14, 2021
    Configuration menu
    Copy the full SHA
    e9b89f1 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Merge branch 'main' of github.com:ampproject/amphtml into bookend_dis… 

    …able
    @mszylkowski
    mszylkowski committed May 17, 2021
    Configuration menu
    Copy the full SHA
    fdefa69 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:ampproject/amphtml into remove_bookend

    @mszylkowski
    mszylkowski committed May 17, 2021
    Configuration menu
    Copy the full SHA
    0809e4e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'bookend_disable' of github.com:mszylkowski/amphtml into… 

    … remove_bookend
    @mszylkowski
    mszylkowski committed May 17, 2021
    Configuration menu
    Copy the full SHA
    43d2c58 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:ampproject/amphtml into remove_bookend

    @mszylkowski
    mszylkowski committed May 17, 2021
    Configuration menu
    Copy the full SHA
    5b5da9e View commit details
    Browse the repository at this point in the history

  5. Fixed test

    @mszylkowski
    mszylkowski committed May 17, 2021
    Configuration menu
    Copy the full SHA
    215123d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'remove_bookendstrs' into remove_bookend

    @mszylkowski
    mszylkowski committed May 17, 2021
    Configuration menu
    Copy the full SHA
    165fd77 View commit details
    Browse the repository at this point in the history

  7. Fixed request service tests

    @mszylkowski
    mszylkowski committed May 17, 2021
    Configuration menu
    Copy the full SHA
    2aec8e1 View commit details
    Browse the repository at this point in the history

  8. Fixed visual tests

    @mszylkowski
    mszylkowski committed May 17, 2021
    Configuration menu
    Copy the full SHA
    b36ca12 View commit details
    Browse the repository at this point in the history

  9. Bring back validation tests for bookend

    @mszylkowski
    mszylkowski committed May 17, 2021
    Configuration menu
    Copy the full SHA
    1092f1c View commit details
    Browse the repository at this point in the history