Allow array spread and rest params

[rcebulko]

No description provided.

[amp-owners-bot]

Hey @erwinmombay! These files were changed:

build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/index.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep-array/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep-array/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/param/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/param/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/output.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/variable-declarations/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/variable-declarations/options.json
+5 more

Hey @jridgewell! These files were changed:

build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/index.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep-array/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep-array/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/param/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/param/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/output.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/variable-declarations/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/variable-declarations/options.json
+8 more

[rcebulko]

@jridgewell bumping this in your GH queue

[jridgewell]

Needs updates to handle ArrayPattern:

• build-system/babel-plugins/babel-plugin-transform-default-assignment/index.js
• build-system/eslint-rules/no-deep-destructuring.js
• build-system/eslint-rules/prefer-destructuring.js
• build-system/eslint-rules/unused-private-field.js

Can be removed:

• build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/index.js

[jridgewell]

Ugh, this shouldn't have been here to start with.

[rcebulko]

Yeah I'd been wondering about this, and if it caused the iterator polyfill to be included regardless. Should I rewrite to use arguments?

[rcebulko]

Needs updates to handle ArrayPattern:

• build-system/babel-plugins/babel-plugin-transform-default-assignment/index.js
• build-system/eslint-rules/no-deep-destructuring.js
• build-system/eslint-rules/prefer-destructuring.js
• build-system/eslint-rules/unused-private-field.js

Can be removed:

• build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/index.js

I can't make heads or tails of a lot of this code. @samouri do you have insights here? Would be happy to pair-program but absolutely lost at first glance

[jridgewell]

I can help later this week. Changes LGTM.