-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Organize polyfills in prep for type-checking and core extraction #34020
Conversation
@jridgewell @rcebulko Looks like this PR introduced a silent failure in the unit tests. Two points:
|
Thanks for looking into this. This is the second time we've had something fail tests but not builds; is this #34040 the same issue as before, or a separate one? |
In this case, the incorrect paths were all in
Probably the same issue. #34040 fixes it at our end by throwing when zero tests are detected (this should never happen normally). @jridgewell Do you think we can get |
…mpproject#34020) * Move rest of polyfills unit tests to test/unit/polyfills * Move polyfill stubs into polyfills/stubs and update imports * Revert debugging change
No description provided.