-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resources: remove intersect-resources experiment #33262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request fixes 1 alert when merging 1df6793 into 1e41922 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 11355e5 into 1115f6c - view on LGTM.com fixed alerts:
|
samouri
requested review from
dvoytenko and
jridgewell
and removed request for
newmuis
March 22, 2021 20:44
dvoytenko
approved these changes
Mar 22, 2021
jridgewell
approved these changes
Mar 22, 2021
|
@jridgewell thanks for pointing out the bundle size diff. I was surprised that it is greater for mjs which is generally more succinct |
This was referenced Oct 19, 2021
This was referenced Nov 5, 2021
This was referenced Jan 18, 2022
Closed
Closed
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Remove
intersect-resources
now that we are moving to "V1" instead (#31915).Having three resources systems would be 2 too many.
Best viewed without whitespace changes.