Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: remove intersect-resources experiment #33262

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

samouri
Copy link
Member

@samouri samouri commented Mar 15, 2021

summary
Remove intersect-resources now that we are moving to "V1" instead (#31915).
Having three resources systems would be 2 too many.

Best viewed without whitespace changes.

@lgtm-com
Copy link

lgtm-com bot commented Mar 22, 2021

This pull request fixes 1 alert when merging 1df6793 into 1e41922 - view on LGTM.com

fixed alerts:

  • 1 for Unreachable statement

@lgtm-com
Copy link

lgtm-com bot commented Mar 22, 2021

This pull request fixes 1 alert when merging 11355e5 into 1115f6c - view on LGTM.com

fixed alerts:

  • 1 for Unreachable statement

@samouri samouri marked this pull request as ready for review March 22, 2021 20:43
@amp-owners-bot amp-owners-bot bot requested a review from newmuis March 22, 2021 20:43
@samouri samouri requested review from dvoytenko and jridgewell and removed request for newmuis March 22, 2021 20:44
@jridgewell
Copy link
Contributor

dist/v0.js: Δ -0.36KB
dist/v0.mjs: Δ -0.51KB

@samouri
Copy link
Member Author

samouri commented Mar 22, 2021

@jridgewell thanks for pointing out the bundle size diff. I was surprised that it is greater for mjs which is generally more succinct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants