🏗 ♻️ Fix type errors in /build-system/tasks/e2e #33166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
force-pushed
the
tsc-e2e
branch
2 times, most recently
from
4e788a0
to
b2d0ac1
Compare
|
Hey @estherkim! These files were changed: |
estherkim
reviewed
Mar 17, 2021
rileyajones
force-pushed
the
tsc-e2e
branch
4 times, most recently
from
b8aef5f
to
66087f5
Compare
rsimha
approved these changes
Apr 13, 2021
Comment on lines
29
to
32
| Browser, // eslint-disable-line no-unused-vars | ||
| JSHandle, // eslint-disable-line no-unused-vars | ||
| Page, // eslint-disable-line no-unused-vars | ||
| ElementHandle: PuppeteerHandle, // eslint-disable-line no-unused-vars |
There was a problem hiding this comment.
Is there a way to avoid these?
There was a problem hiding this comment.
I could condense them, or else I could try to do some dynamic typing or just drop type enforcement. I'll update this PR soon with all these condensed to just puppeteer.
rileyajones
commented
Apr 13, 2021
Comment on lines
+82
to
96
| * @param {function(CONDITION, function(VALUE): ?DERIVED): Promise<RES>} wait | ||
| * @param {function(VALUE): MUTANT} mutate | ||
| * @return {function(CONDITION, function(MUTANT): ?DERIVED): Promise<RES>} | ||
| * @template CONDITION | ||
| * @template MUTANT | ||
| * @template DERIVED | ||
| * @template VALUE | ||
| * @template RES | ||
| */ | ||
| function wrapWait(wait, mutate) { | ||
| return (condition, opt_mutate) => { | ||
| opt_mutate = opt_mutate || ((x) => x); | ||
| opt_mutate = opt_mutate || ((x) => /** @type {*} */ (x)); | ||
| return wait(condition, (value) => opt_mutate(mutate(value))); | ||
| }; | ||
| } |
There was a problem hiding this comment.
This was a heck of a puzzle. More than open to changing type names etc...
estherkim
approved these changes
Apr 14, 2021
rileyajones
added a commit
to rileyajones/amphtml
that referenced
this pull request
Apr 16, 2021
* fix errors in /tasts/e2e * update typing in puppeteer-controller * solve controller-promise typing puzzle
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
* fix errors in /tasts/e2e * update typing in puppeteer-controller * solve controller-promise typing puzzle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/build-system/tasks/e2e is directory which contains the largest number of type errors of any of build-system tasks. This PR is intended to be non functional and should resolve all simple type errors within the subdirectory. After this lands there will still be a handful of non trivial errors requiring functional changes that will be fixed as part of another PR.
#28387