-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Sync Chrome version used by Visual tests with Percy backend #32774
🏗 Sync Chrome version used by Visual tests with Percy backend #32774
Conversation
Hey @danielrozenberg! These files were changed:
|
This version did not work: https://app.circleci.com/pipelines/github/ampproject/amphtml/2336/workflows/c7aa7989-fe8a-44da-8125-00ba1cae5f32/jobs/25482/parallel-runs/0/steps/0-108 @danielrozenberg Any other ideas? Do you know if there's a way to tell which sub-versions of Chrome 87 will work with puppeteer? |
No idea why, but |
New snapshots all appear to be more correct than the current baseline. Let's merge this and pay attention to overall flakiness. |
Visual tests have been flaky of late because the Percy backend was using Chrome v78. We therefore pinned our CI to that version while running visual tests. Now, Percy has moved to v87.
This PR pins our CI to the current stable channel version v88. This will be the way to go until Percy agrees to regularly update to Chrome stable channel.