Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CustomElement.build to buildInternal #32342

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Feb 1, 2021

Partial for #31915.

This is a very trivial refactoring, but a lot of test diffs. Need for a more complete #32002 refactoring.

@dvoytenko dvoytenko marked this pull request as ready for review February 2, 2021 02:04
@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 2, 2021

Hey @alanorozco! These files were changed:

extensions/amp-3q-player/0.1/test/test-amp-3q-player.js
extensions/amp-brid-player/0.1/test/test-amp-brid-player.js
extensions/amp-connatix-player/0.1/test/test-amp-connatix-player.js
extensions/amp-delight-player/0.1/test/test-amp-delight-player.js
extensions/amp-kaltura-player/0.1/test/test-amp-kaltura-player.js
extensions/amp-minute-media-player/0.1/test/test-amp-minute-media-player.js
extensions/amp-nexxtv-player/0.1/test/test-amp-nexxtv-player.js
extensions/amp-o2-player/0.1/test/test-amp-o2-player.js
extensions/amp-powr-player/0.1/test/test-amp-powr-player.js
extensions/amp-reach-player/0.1/test/test-amp-reach-player.js
extensions/amp-springboard-player/0.1/test/test-amp-springboard-player.js
extensions/amp-viqeo-player/0.1/test/test-amp-viqeo-player.js
+1 more

Hey @gmajoulet, @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/test/test-amp-story-page.js
extensions/amp-story/1.0/test/test-amp-story.js

@samouri
Copy link
Member

samouri commented Feb 2, 2021

Can you explain the rename? Are you making a new build() that uses buildInternal?

@dvoytenko
Copy link
Contributor Author

Can you explain the rename? Are you making a new build() that uses buildInternal?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants