-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CustomElement.build to buildInternal #32342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @alanorozco! These files were changed:
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed:
|
dvoytenko
force-pushed
the
run3/build-internal
branch
from
February 2, 2021 02:08
8c9dcaa
to
79669fe
Compare
Can you explain the rename? Are you making a new |
dvoytenko
force-pushed
the
run3/build-internal
branch
from
February 2, 2021 03:57
79669fe
to
caef123
Compare
Yes. |
samouri
approved these changes
Feb 2, 2021
Enriqe
approved these changes
Feb 2, 2021
dvoytenko
force-pushed
the
run3/build-internal
branch
from
February 2, 2021 23:17
caef123
to
755df2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #31915.
This is a very trivial refactoring, but a lot of test diffs. Need for a more complete #32002 refactoring.