Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 [test-case-reporting] Run gulp tasks & add flags when pushing #29495

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

Rafer45
Copy link
Contributor

@Rafer45 Rafer45 commented Jul 24, 2020

/cc @rcebulko @estherkim
Closes ampproject/amp-github-apps#922

EDIT: Normally, we can't tell whether or not these changes break the build (since they only run on push builds). However, manually enabling the flags for the PR build didn't break the build, as shown in the following link: https://travis-ci.org/github/ampproject/amphtml/builds/711576997

@google-cla google-cla bot added the cla: yes label Jul 24, 2020
.eslintignore Outdated Show resolved Hide resolved
@Rafer45 Rafer45 marked this pull request as ready for review July 24, 2020 20:40
@amp-owners-bot
Copy link

Hey @rsimha! These files were changed:

build-system/pr-check/local-tests.js

Copy link
Collaborator

@estherkim estherkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean! 2 questions:

  1. We run integration tests in more places - dist-tests and experiment-tests, off the top of my head. Is the idea to report those too?
  2. Do you plan on adding this to our GH actions test runs?

@Rafer45
Copy link
Contributor Author

Rafer45 commented Jul 27, 2020

Nice and clean! 2 questions:

  1. We run integration tests in more places - dist-tests and experiment-tests, off the top of my head. Is the idea to report those too?
  2. Do you plan on adding this to our GH actions test runs?
  1. Depends on whether the karma reporter works for those; if it does, there should be no issue reporting them as well.
  2. I should probably do that; I'm not sure, though -- some of the structure (the use of "builds" and "jobs") is Travis-dependent. I'll ping @rcebulko on this one.

@rcebulko
Copy link
Contributor

Nice and clean! 2 questions:

  1. We run integration tests in more places - dist-tests and experiment-tests, off the top of my head. Is the idea to report those too?
  2. Do you plan on adding this to our GH actions test runs?
  1. Depends on whether the karma reporter works for those; if it does, there should be no issue reporting them as well.
  2. I should probably do that; I'm not sure, though -- some of the structure (the use of "builds" and "jobs") is Travis-dependent. I'll ping @rcebulko on this one.
  1. Tests where we can support reporting out-of-the-box with the karma reporter should probably eventually be included, but for now settling with local tests should be sufficient.
  2. Likewise, GitHub Actions test runs can and should eventually be reported, but that will likely require some tweaks to the DB to add tables for GA runs separate from Travis jobs. This may fall into Ricardo's scope depending on how much progress is made elsewhere, but generally the plan is to add support for alternate CI later on/as the alternatives are fleshed out, since we're actively experimenting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test-case-reporting] Move Travis POSTing to its own gulp task
4 participants