[amp-story-player] Entry point skeleton code and bundle #28999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
approved these changes
Jun 23, 2020
newmuis
reviewed
Jun 23, 2020
src/amp-story-player/amp-story-entry-point/amp-story-entry-point.js
Outdated
Show resolved
Hide resolved
Enriqe
force-pushed
the
entry-points-bundle
branch
2 times, most recently
from
1f1f1a9
to
5598634
Compare
gmajoulet
approved these changes
Jun 24, 2020
gmajoulet
reviewed
Jun 24, 2020
| this.rootEl_ = this.doc_.createElement('main'); | ||
|
|
||
| // Create shadow root | ||
| const shadowRoot = this.element_.attachShadow({mode: 'open'}); |
There was a problem hiding this comment.
This will fail on many browsers, we should have a fallback.
There was a problem hiding this comment.
I'll address as a follow-up since this is something that we also do for the player.
There was a problem hiding this comment.
Sounds good, is is tracked somewhere?
Enriqe
force-pushed
the
entry-points-bundle
branch
from
5598634
to
3ca5cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #26308
Adds
<amp-story-entry-point>skeleton files and generates bundle. I thought it would be a good idea to leverage our existing "runtime" (AmpStoryPlayerManager) to handle the lifecycle of the entry points as well, but that's open for discussion.