✨[amp-story-player] Adds swipe-to-next/previous story #27173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmajoulet
reviewed
Mar 10, 2020
gmajoulet
approved these changes
Mar 11, 2020
twintwox
pushed a commit
to twintwox/amphtml
that referenced
this pull request
Mar 24, 2020
* adds swiping * types * wrap animations in rAF, add test, decrease animation duration * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds swiping between stories.
Demo (mobile only)
Includes:
touchstart,touchend,touchmoveevents sent by the AMP doc.Does not include:
preventDefaultorstopPropagationon it. This can be verified in this demo, notice how the touchEvents are logged outside the iframe but not when they're inside.Closes #26698
Tracker #26308