🚫 [amp-story-player] Temporarily disable messaging #26604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 6556e78 into 05046f6 - view on LGTM.com new alerts:
|
gmajoulet
approved these changes
Feb 3, 2020
|
This pull request introduces 1 alert when merging 7814258 into e0500b7 - view on LGTM.com new alerts:
|
newmuis
reviewed
Feb 4, 2020
src/amp-story-player.js
Outdated
| @@ -22,6 +22,8 @@ import { | |||
| parseUrlWithA, | |||
| removeFragment, | |||
| } from './url'; | |||
| // Source for this constant is css/amp-story-player-iframe.css | |||
| import {cssText} from '../build/amp-story-player-iframe.css'; | |||
There was a problem hiding this comment.
Should we still just import this as the name CSS? That's what we use in e.g. extension files
There was a problem hiding this comment.
cssText is the exported name when defined in build-system/tasks/css.js. Extension CSS goes through a different part of the build pipeline that names it CSS 🤷♀️
Enriqe
changed the title
|
I split the css part into another PR #26613 👍 |
Enriqe
changed the title
|
This pull request introduces 1 alert when merging 7046d12 into 9bc8756 - view on LGTM.com new alerts:
|
gmajoulet
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #24539 #26308