Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [amp-list] Introduce "amp-state:" as a usable protocol for the src attribute. #26284

Merged
merged 27 commits into from
Jan 28, 2020
Merged

✨ [amp-list] Introduce "amp-state:" as a usable protocol for the src attribute. #26284

merged 27 commits into from
Jan 28, 2020

Commits on Jan 27, 2020

  1. Initialize amp-list from SSRed amp-state

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    17589a6 View commit details
    Browse the repository at this point in the history

  2. The hackiest of hacks

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    4fb982e View commit details
    Browse the repository at this point in the history

  3. TODO: experimentify

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    4c42528 View commit details
    Browse the repository at this point in the history

  4. use experimetn btr

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    8f3d99f View commit details
    Browse the repository at this point in the history

  5. clean up error msges

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    2c37a35 View commit details
    Browse the repository at this point in the history

  6. add test placeholders

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    0ab86d9 View commit details
    Browse the repository at this point in the history

  7. finish adding in tests

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    0cbabf0 View commit details
    Browse the repository at this point in the history

  8. remove trims

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    27fb62e View commit details
    Browse the repository at this point in the history

  9. privatify

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    45bc722 View commit details
    Browse the repository at this point in the history

  10. remove support for post-init amp-state protocol

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    8dcd690 View commit details
    Browse the repository at this point in the history

  11. add new unit test for attempts to set post-init src to amp-state

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    0bac916 View commit details
    Browse the repository at this point in the history

  12. loosen it all up

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    4d59a23 View commit details
    Browse the repository at this point in the history

  13. fetch always means fetch

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    92d906e View commit details
    Browse the repository at this point in the history

  14. make a clearer distinction between amp-stae: renders and bind expr re… 

    …nders
    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    bc53467 View commit details
    Browse the repository at this point in the history

  15. Address choumx's feedback.

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    19c189f View commit details
    Browse the repository at this point in the history

  16. user().assert --> userAssert

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    aeb9880 View commit details
    Browse the repository at this point in the history

  17. add in example

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    a2b07e0 View commit details
    Browse the repository at this point in the history

  18. Revert some changes now that amp-state protocol is more similar to a … 

    …fetch than to synchronous local data
    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    f5a789c View commit details
    Browse the repository at this point in the history

  19. Caro updates

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    7003ff5 View commit details
    Browse the repository at this point in the history

  20. WHOOPS

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    4952f61 View commit details
    Browse the repository at this point in the history

  21. Promise<*> for getAmpStateJson

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    8a26381 View commit details
    Browse the repository at this point in the history

  22. Emit warning for the // can never happen // case

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    80a2558 View commit details
    Browse the repository at this point in the history

  23. resolve jridgewell comments

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    db5d9bd View commit details
    Browse the repository at this point in the history

  24. restrict amp-state: to just initialization.

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    f4f2eda View commit details
    Browse the repository at this point in the history

  25. fix tests

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    3445016 View commit details
    Browse the repository at this point in the history

  26. simplify fetch expectations and make more consistent with xhr

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    daeeacb View commit details
    Browse the repository at this point in the history

  27. fix basic example

    @samouri
    samouri committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    09fdd96 View commit details
    Browse the repository at this point in the history