Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed nativeroll's player collapse & resize bug #23656

Merged
merged 7 commits into from
Aug 8, 2019
Merged

fixed nativeroll's player collapse & resize bug #23656

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d81a4d1
fixed nativeroll's player collapse bug
n-randin Aug 2, 2019
0b6e043
window from global
n-randin Aug 2, 2019
7292514
use global & adding requestResize on content load
n-randin Aug 6, 2019
ba0b56f
Merge branch 'nativeroll' of github.com:n-randin/amphtml into nativeroll
n-randin Aug 6, 2019
5292a32
use global & adding requestResize on content load
n-randin Aug 6, 2019
eca9836
/*ok*/ to the offsetHeight
n-randin Aug 6, 2019
f75c6d0
pass global as param
n-randin Aug 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ads/nativeroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ function initPlayer(data) {
container: '#c',
desiredOffset: 50,
gid: data.gid,
onError: () => {
global.context.noContentAvailable();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need pass global object as function param

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok, did not immediately understand what you mean. Done this.

},
onLoad: () => {
const height = global.document.getElementsByClassName('nr-player')[0]
./* OK */ offsetHeight;
global.context.requestResize(undefined, height);
},
};
// eslint-disable-next-line no-undef
SeedrPlayer(config);
Expand Down
7 changes: 4 additions & 3 deletions examples/ads.amp.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,9 @@
<input type="submit" value="Go">
</form>
</div>

<h2>1WO</h2>
<amp-embed
<amp-embed
width="400"
height="700"
type="1wo"
Expand All @@ -287,7 +287,7 @@ <h2>1WO</h2>
data-owo-mode="smart3"
src="https://frontend-qa.1worldonline.biz/poller-constructor.js">
</amp-embed>

<h2>24smi</h2>
<amp-embed width="250" height="250"
type="24smi"
Expand Down Expand Up @@ -1463,6 +1463,7 @@ <h2>myWidget</h2>

<h2>Nativeroll</h2>
<amp-ad width="480" height="340"
layout="responsive"
type="nativeroll"
data-gid="5d10df709762b6b31b8b461e"
>
Expand Down