🐛 Animation improvements #23322
Merged
🐛 Animation improvements #23322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So sorry about this, didn't think of it before I saw the AnimationTypedef reviewing this PR, but could you try simply passing the delay to the animation runner? I think it'd need more work than this commit, but could you look into how this simplifies your PR? |
gmajoulet
reviewed
Jul 15, 2019
| @@ -283,13 +269,25 @@ class AnimationRunner { | |||
|
|
|||
| /** Pauses the animation. */ | |||
| pause() { | |||
| // Animation hasn't started yet since it's waiting for a sequenced | |||
| // animation. | |||
| if (this.scheduledActivity_ !== null) { | |||
There was a problem hiding this comment.
Given your comment, wouldn't this.scheduledWait_ be more accurate?
gmajoulet
approved these changes
Jul 15, 2019
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
* animation improvements * fix types * welp... * use scheduleWait_ var instead
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* animation improvements * fix types * welp... * use scheduleWait_ var instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a number of fixes for animation bugs that we've had for a while related to hold-to-pause.
1: Console errors were showing up due to animations that hadn't started yet. This was due to the fact that we weren't checking if the animation was still waiting for another animation or had a delay.
2: When an animation with a delay was paused, it ignored the pausing and continued to animate. Fixes #23224
3: When an animation with a delay hadn't started yet, and the user navigated to another page and then came back, the delay wasn't being restarted, so it would appear right away on page landing.
To address these, I separated the
getStartWaitPromise_and a newgetDelayWaitPromise_that is only in charge of the delay. Each delay will get adelayId_and adelayStartTime_. With these, we are able to cancel and restart thedelayfor the corresponding animation.EDIT: the above paragraph's approach wasn't necessary. We only needed to include the delay in the animation keyframe definition (see latest commit).