Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piano analytics support #2279

Closed

Conversation

nathangoulding
Copy link
Contributor

Fixes issue #1769.

@avimehta
Copy link
Contributor

avimehta commented Mar 1, 2016

@nathangoulding : Can you update vendor-requests.js to add the requests for piano analytics? The tests are currently failing because of them.

@nathangoulding
Copy link
Contributor Author

@avimehta I updated vendor-requests.json which is passing tests now but still seeing this test failing:

amp-youtube renders FAILED
    Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.

@avimehta
Copy link
Contributor

No clue. Try pushing out the commit. Sometimes Travis does not see the same
failures as local tests.
On Mar 17, 2016 9:44 AM, "Nathan Goulding" [email protected] wrote:

@avimehta https://github.com/avimehta I updated vendor-requests.json
which is passing tests now but still seeing this test failing:

amp-youtube renders FAILED
Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2279 (comment)

@nathangoulding
Copy link
Contributor Author

This is actually from Travis not locally.

@avimehta
Copy link
Contributor

sorry about that. That test seems to be failing on master at HEAD. It's probably not related to your change.

Can you squash all your commits and rebase? Once done, I'll merge.

Thanks for the patience.

@nathangoulding
Copy link
Contributor Author

Closed in favor of #2624.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants