♻️✨ amp-fx=float-in-(top|bottom) #20905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
commented
Feb 18, 2019
alanorozco
force-pushed
the
scroll-toggle
branch
from
d0b5a65
to
c03934e
Compare
honeybadgerdontcare
approved these changes
Feb 18, 2019
extensions/amp-scroll-toggle/validator-amp-scroll-toggle.protoascii
Outdated
Show resolved
Hide resolved
extensions/amp-scroll-toggle/validator-amp-scroll-toggle.protoascii
Outdated
Show resolved
Hide resolved
extensions/amp-scroll-toggle/0.1/test/validator-amp-scroll-toggle.html
Outdated
Show resolved
Hide resolved
|
@aghassemi @cvializ @honeybadgerdontcare Moved to |
honeybadgerdontcare
approved these changes
Feb 20, 2019
alanorozco
commented
Feb 20, 2019
| */ | ||
| export class FxProvider { |
There was a problem hiding this comment.
@cvializ @aghassemi This class was akin to a simple function and was only keeping memory alive, simplified.
alanorozco
force-pushed
the
scroll-toggle
branch
from
3cf3cfc
to
d48f23a
Compare
alanorozco
changed the title
|
This pull request fixes 1 alert when merging b764f2d into c33eb82 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
alanorozco
force-pushed
the
scroll-toggle
branch
from
e678444
to
be2d1c3
Compare
alanorozco
force-pushed
the
scroll-toggle
branch
from
be2d1c3
to
82afebd
Compare
|
This pull request fixes 1 alert when merging 82afebd into ee8daa8 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
twifkak
reviewed
Feb 27, 2019
Gregable
added a commit
that referenced
this pull request
Feb 27, 2019
* cl/234896906 Revision bump for #20969 * cl/235090073 Allow i-amphtml-layout on AMP elements only for Transformed AMP * cl/235216325 Disallow document properties in <form> attribute name. * cl/235271919 Revision bump for #20989 * cl/235833553 Revision bump for #20928 * cl/235843207 Revision bump for #20905
alanorozco
added a commit
that referenced
this pull request
Mar 8, 2019
jridgewell
pushed a commit
that referenced
this pull request
Mar 12, 2019
jridgewell
pushed a commit
that referenced
this pull request
Mar 14, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
Partial for ampproject#20881. Base implementation for `amp-fx="float-in-(top|bottom)"`. Slides elements in-and-out accordingly. Matches behavior of Google viewer's sliding header, see http://go/amp-viewer-scroll and http://go/amp-viewer-scroll-thresholds internally. Demo: https://scroll-toggle.glitch.me/ Also: * refactors `amp-fx-collection` for types and size. (~10% down from total bundle) * adds a bunch of string → types tests (and killed a splice bug, thanks @amphtml-lgtm-bot!)
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* cl/234896906 Revision bump for ampproject#20969 * cl/235090073 Allow i-amphtml-layout on AMP elements only for Transformed AMP * cl/235216325 Disallow document properties in <form> attribute name. * cl/235271919 Revision bump for ampproject#20989 * cl/235833553 Revision bump for ampproject#20928 * cl/235843207 Revision bump for ampproject#20905
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
Mea culpa. Fixes ampproject#21332 introduced by ampproject#20905. Will introduce tests in a later PR so this won't happen again.
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
Partial for ampproject#20881. Base implementation for `amp-fx="float-in-(top|bottom)"`. Slides elements in-and-out accordingly. Matches behavior of Google viewer's sliding header, see http://go/amp-viewer-scroll and http://go/amp-viewer-scroll-thresholds internally. Demo: https://scroll-toggle.glitch.me/ Also: * refactors `amp-fx-collection` for types and size. (~10% down from total bundle) * adds a bunch of string → types tests (and killed a splice bug, thanks @amphtml-lgtm-bot!)
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* cl/234896906 Revision bump for ampproject#20969 * cl/235090073 Allow i-amphtml-layout on AMP elements only for Transformed AMP * cl/235216325 Disallow document properties in <form> attribute name. * cl/235271919 Revision bump for ampproject#20989 * cl/235833553 Revision bump for ampproject#20928 * cl/235843207 Revision bump for ampproject#20905
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
Mea culpa. Fixes ampproject#21332 introduced by ampproject#20905. Will introduce tests in a later PR so this won't happen again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #20881.
Base implementation for
amp-fx="float-in-(top|bottom)". Slides elements in-and-out accordingly. Matches behavior of Google viewer's sliding header, see go/amp-viewer-scroll and go/amp-viewer-scroll-thresholds internally.Demo: https://scroll-toggle.glitch.me/
Also:
amp-fx-collectionfor types and size. (~10% down from total bundle)Work after this change
mediaattribute.togglemessage to short-circuit duplicate behavior.