🚀 Wait for mutate phase before layoutCallback #20814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resources itself is in a measure phase when it schedules layoutCallbacks.
jridgewell
changed the title
cramforce
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
I'm, uhm, scared and/or happy if this doesn't break any tests.
Let's wait for @dvoytenko before merging.
dvoytenko
approved these changes
Feb 13, 2019
jridgewell
force-pushed
the
startLayout-mutate-phase
branch
from
65b2c1e
to
f186c98
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Wait for mutate phase before layoutCallback Resources itself is in a measure phase when it schedules layoutCallbacks. * Lint * Fix resource tests * Fix integration tests * Attempt to fix carousel tests * Skip broken integration tests
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* Wait for mutate phase before layoutCallback Resources itself is in a measure phase when it schedules layoutCallbacks. * Lint * Fix resource tests * Fix integration tests * Attempt to fix carousel tests * Skip broken integration tests
This was referenced Apr 22, 2020
This was referenced May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources itself is in a measure phase when it schedules layoutCallbacks.
Fixes #20770