🐛amp-analytics Stop adding triggers if has been detached #18340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should just go ahead and check Looking at the code, the race condition can happen from 2 places:
Once either of the above async execution took too much time and amp-analytics gets detached from DOM, we will get this error. So we definitely to have a null check to protect. |
|
As I mentioned I agree that check for |
|
@lannka Changed to check |
|
Friendly ping |
lannka
approved these changes
Oct 16, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Oct 18, 2018
…18340) * check if has detached * change check to analyticsGroup * fix test
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…18340) * check if has detached * change check to analyticsGroup * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #18231
Note: Ideally we should add the check before initiating every instance, but that's too much check.
Once we've confirmed that detachedCallback is the root cause to #18231, we can remove the
this.hasDetached_and check forthis.analyticsGroup_instead.