📖 Update docs for amp-gist to indicate height does not have to be obtained up front #17738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed their request for review
CrystalOnScript
approved these changes
Aug 29, 2018
cathyxz
approved these changes
Sep 1, 2018
|
Thank you @westonruter ! |
jeherve
pushed a commit
to Automattic/jetpack
that referenced
this pull request
Sep 26, 2018
…10053) #### Changes proposed in this Pull Request: * Return `amp-gist` from a `gist` shortcode or oEmbed when in an AMP response. #### Testing instructions: 1. Install the [AMP plugin](https://github.com/Automattic/amp-wp). 2. Add a `gist` shortcode or gist oEmbed URL to a post. Then view that post in AMP. 3. View the AMP version of the post. Example content: ```html oEmbed: Full gist: https://gist.github.com/sebastianbenz/1d449dee039202d8b7464f1131eae449 oEmbed: Linking to a file via in a Gist: https://gist.github.com/sebastianbenz/1d449dee039202d8b7464f1131eae449#file-sw-html oEmbed: Linking to file without username in URL. https://gist.github.com/1d449dee039202d8b7464f1131eae449#file-sw-html Example from WordPress.com docs: [gist https://gist.github.com/2314628 /] Second example from WordPress.com docs: [gist]2314628[/gist] ``` Originally proposed in ampproject/amp-wp#375 See also ampproject/amphtml#17738 for details on the `amp-gist`'s `height` attribute. #### Proposed changelog entry for your changes: * Add Gist support for AMP responses.
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docs for
amp-gistfor itsheightattribute, there is a note:This turns out not to be true. If the exact height is not specified, the gist will get resized to be the proper dimensions once the gist loads:
amphtml/extensions/amp-gist/0.1/amp-gist.js
Lines 63 to 66 in 2f51873
So I believe the
heightshould be marked as recommended, or that it is the initial height of the gist.