Do not duplicate the listeners when using media based advancement start/stop methods. #17289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmajoulet
force-pushed
the
no_duplicate_listeners_media_based_advance
branch
from
0819c1c
to
ae47f8a
Compare
Enriqe
approved these changes
Aug 3, 2018
gmajoulet
force-pushed
the
no_duplicate_listeners_media_based_advance
branch
from
ae47f8a
to
6a6cd84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not duplicate the listeners when using media based advancement start/stop methods.
Because the
PAUSED_STATEcalls theMediaBasedAdvancement.startandMediaBasedAdvancement.stopmethods, it can happen that we duplicate the media advancement listeners (timeupdate and ended).That's bad for performance, but led to a bug where it'd call the
switchTomethod multiple times when the video ends, breaking the story navigation.