Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Run pre-push tests in headless mode #17284

Merged
merged 1 commit into from
Aug 3, 2018
Merged

🏗 Run pre-push tests in headless mode #17284

merged 1 commit into from
Aug 3, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Aug 3, 2018 •
edited
Loading

This makes the pre-push tests less annoying, and more likely to pass (inadvertent clicks on the test window can fail them).

@rsimha rsimha self-assigned this Aug 3, 2018
@rsimha
Copy link
Contributor Author

rsimha commented Aug 3, 2018

/to @kristoferbaxter @jpettitt @choumx @jridgewell

kristoferbaxter
kristoferbaxter approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea.

@rsimha rsimha merged commit 31188af into ampproject:master Aug 3, 2018
@rsimha rsimha deleted the 2018-08-03-PrepushHeadless branch August 3, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

@jpettitt jpettitt Awaiting requested review from jpettitt

@jridgewell jridgewell Awaiting requested review from jridgewell

@dreamofabear dreamofabear Awaiting requested review from dreamofabear

Assignees

@rsimha rsimha

Labels
cla: yes WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsimha @kristoferbaxter @googlebot