🐛 Fix docs for amp-position-observer s/target-id/target/ #17272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
changed the title
|
/cc @pbakaus |
Codecov Report
@@ Coverage Diff @@
## master #17272 +/- ##
==========================================
- Coverage 77.75% 77.32% -0.43%
==========================================
Files 564 565 +1
Lines 41218 41540 +322
==========================================
+ Hits 32047 32122 +75
- Misses 9171 9418 +247
Continue to review full report at Codecov.
|
kevinkassimo
pushed a commit
to kevinkassimo/amphtml
that referenced
this pull request
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
amp-position-observerdocs incorrectly state that there is atarget-idattribute:It should actually be just
target:amphtml/extensions/amp-position-observer/validator-amp-position-observer.protoascii
Line 45 in 1143ef0