Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove guards for launched 'inline-styles' experiment #17187

Merged

Conversation

dreamofabear
Copy link

Fixes #13595.

/to @alabiaga

Copy link
Contributor

@alabiaga alabiaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls edit test/functional/test-fixed-layer.js as well.

@dreamofabear
Copy link
Author

@alabiaga Done.

@dreamofabear dreamofabear force-pushed the remove-inline-styles-experiment branch from 45d4f78 to 11b1c52 Compare August 1, 2018 18:48
@dreamofabear dreamofabear force-pushed the remove-inline-styles-experiment branch from 11b1c52 to 9036dec Compare August 1, 2018 20:31
@codecov-io
Copy link

codecov-io commented Aug 2, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8056da5). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master   #17187   +/-   ##
=========================================
  Coverage          ?   77.81%           
=========================================
  Files             ?      562           
  Lines             ?    41193           
  Branches          ?        0           
=========================================
  Hits              ?    32053           
  Misses            ?     9140           
  Partials          ?        0
Flag Coverage Δ
#integration_tests 36.09% <0%> (?)
#unit_tests 76.86% <100%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8056da5...72f4edc. Read the comment docs.

@dreamofabear dreamofabear merged commit 38e6a3b into ampproject:master Aug 2, 2018
@dreamofabear dreamofabear deleted the remove-inline-styles-experiment branch August 2, 2018 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants