-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CSS scroll snap code across more browsers #17058
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17058 +/- ##
==========================================
- Coverage 77.88% 76.5% -1.38%
==========================================
Files 562 563 +1
Lines 41156 43863 +2707
==========================================
+ Hits 32054 33558 +1504
- Misses 9102 10305 +1203
Continue to review full report at Codecov.
|
This change looks fine, but will probably require very extensive testing on all relevant devices / browsers to see if it breaks anything. Do you mind commenting with a checklist here (or just assigning the PR to me) after that's been done? |
Tracking manual testing on the following platforms:
|
Logging offline discussion: Turning this into an experiment with following movement:
@cathyxz take a look? |
I think we made a new rule banning creating experiments and flipping flags in the same PR. It makes for easier reverts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just move the flag flip to a different PR.
@cathyxz - Split up the canary-config change into it's own PR. |
Safari/Firefox/Edge have scroll-snap enabled. Chrome now has it enabled starting 69.
This PR enables scroll snap code for all browsers/OSes.
Addresses: #16508