Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-bind: Support multiple args in Array.reduce() #16960

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

dreamofabear
Copy link

@dreamofabear dreamofabear commented Jul 20, 2018

Fixes #12349.

/to @alabiaga

@codecov-io
Copy link

Codecov Report

Merging #16960 into master will decrease coverage by 0.18%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #16960      +/-   ##
==========================================
- Coverage    78.1%   77.92%   -0.19%     
==========================================
  Files         561      561              
  Lines       40754    41631     +877     
==========================================
+ Hits        31831    32439     +608     
- Misses       8923     9192     +269
Flag Coverage Δ
#integration_tests 34.46% <11.11%> (-0.01%) ⬇️
#unit_tests 77% <100%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 860a5c1...069c70c. Read the comment docs.

@dreamofabear dreamofabear requested review from alabiaga and removed request for jridgewell August 1, 2018 18:45
@dreamofabear dreamofabear merged commit ea37aa0 into ampproject:master Aug 6, 2018
@dreamofabear dreamofabear deleted the bind-reduce-args branch August 6, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants