✨ AMP Analytics Iframe Transport Configuration for Moat #16710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
reviewed
Jul 30, 2018
| @@ -2094,6 +2095,139 @@ export const ANALYTICS_CONFIG = /** @type {!JsonObject} */ ({ | |||
| }, | |||
| }, | |||
|
|
|||
| 'moat': { | |||
| 'requests': { | |||
| 'load': '{' + | |||
There was a problem hiding this comment.
you should be able to use JSON.stringfy here
Codecov Report
@@ Coverage Diff @@
## master #16710 +/- ##
==========================================
- Coverage 77.78% 77.73% -0.06%
==========================================
Files 562 564 +2
Lines 41199 41217 +18
==========================================
- Hits 32048 32040 -8
- Misses 9151 9177 +26
Continue to review full report at Codecov.
|
|
you probably missed my previous comment could you do JSON.stringify() in vendors.js to have better readability? |
|
@lannka thank you for the suggestion, we have converted the string into a JSON object. |
lannka
approved these changes
Aug 3, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the required configuration settings to allow Moat to measure AMPHTML ads.