amp-access onApplyAuthorizations callbacks. #16471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmajoulet
force-pushed
the
access_authorizations_callback
branch
from
a3b4f71
to
07b4128
Compare
|
I defer to @dvoytenko, but this looks pretty straightforward and LGTM |
Codecov Report
@@ Coverage Diff @@
## master #16471 +/- ##
=========================================
Coverage ? 78.11%
=========================================
Files ? 549
Lines ? 40038
Branches ? 0
=========================================
Hits ? 31274
Misses ? 8764
Partials ? 0Continue to review full report at Codecov.
|
|
Let's go ahead with this PR. @gmajoulet can you rebase? |
gmajoulet
force-pushed
the
access_authorizations_callback
branch
from
07b4128
to
37756b9
Compare
|
Done :) Side note: this is meant for the internal implementation of |
kevinkassimo
pushed a commit
to kevinkassimo/amphtml
that referenced
this pull request
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The STAMP implementation of
amp-accessprevents the user from navigating to a protected page (amp-access=<condition>).It waits for the user to log in, and the document to be reauthorized before actually displaying the next page.
This PR implements a way for
amp-storyto know when the document has been reauthorized, so it can maybe navigate to the next page, if unblocked.#12180