Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable console error check in test-amp-analytics.js unti… #15606

Merged
merged 2 commits into from
May 25, 2018
Merged

Temporarily disable console error check in test-amp-analytics.js unti… #15606

merged 2 commits into from
May 25, 2018

Conversation

lannka
Copy link
Contributor

@lannka lannka commented May 25, 2018

…l we have a solution to catch async console errors.

@lannka
Temporarily disable console error check in test-amp-analytics.js unti…
61acf03 
…l we have a solution to catch async console errors.
@lannka lannka requested a review from rsimha May 25, 2018 20:58
rsimha
rsimha approved these changes May 25, 2018
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this out. And yeah, let's chat about how we can catch async errors.

@rsimha rsimha mentioned this pull request May 25, 2018
Closed
@lannka lannka merged commit df9fab8 into ampproject:master May 25, 2018
@lannka lannka deleted the disable_console_error_check branch May 25, 2018 22:21
@rsimha rsimha mentioned this pull request May 26, 2018
Merged
@rsimha
Copy link
Contributor

rsimha commented May 26, 2018

@lannka This workaround should no longer be necessary after #15621. I've reverted these changes and sent out a proper solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lannka @rsimha @googlebot