🐛: Reject layoutCallback promise when throw #15410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
reviewed
May 17, 2018
src/custom-element.js
Outdated
| this.classList.add('i-amphtml-layout'); | ||
|
|
||
| let promise; | ||
| try { |
There was a problem hiding this comment.
you can use:
Line 70 in e21f78c
zhouyx
force-pushed
the
fix-layoutCallback-throw
branch
from
47e37f9
to
3e49c31
Compare
|
cc @jridgewell |
zhouyx
force-pushed
the
fix-layoutCallback-throw
branch
from
3e49c31
to
a98c056
Compare
This was referenced Apr 8, 2020
This was referenced Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing error synchronously breaks
#layoutCallback, because it won't return a promise. And the handler for promise reject will never run.