Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramp up amp-img-native-srcset experiment to 1% #15200

Merged
merged 2 commits into from
May 11, 2018
Merged

Ramp up amp-img-native-srcset experiment to 1% #15200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72ba40c
Ramp up amp-img-native-srcset experiment to 1%
cathyxz May 10, 2018
f4e3d35
Undo 1% prod-config.json
cathyxz May 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build-system/global-configs/canary-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
"expUnconditionedAdxIdentity": 0.01,
"expUnconditionedDfpIdentity": 0.01,
"expUnconditionedCanonicalHoldback": 0.01,
"amp-consent": 1
"amp-consent": 1,
"amp-img-native-srcset": 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @erwinmombay Does Canary config differing from Prod config actually work? ( I don't remember ever doing this in the past. It does make sense for us to do this here, just want to make sure it actually does something)

Copy link
Contributor Author

@cathyxz cathyxz May 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ampproject/amphtml/blob/89b69a952b27c091e2a594a297a73c1afcbcf800/build-system/global-configs/README.md

I think per this documentation, canary-config.json is actually just 1% of production, so for 1%, we can just opt in all of canary and leave production alone.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah Canary always goes to 1% of production on or around Wednesdays anyway. it is fine to keep what you have. May endup being ~1.5%

}