Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'element alias' registration #1517

Closed
wants to merge 1 commit into from

Conversation

nitzanvolman
Copy link
Contributor

Create the ability to register elements as aliases to other elements.
Allows code re-use when a required tag functionality already exists, but required for a different tag.
Specific use case is amp-taboola which derives it's functionality from amp-ad but requires a different name.
separating this PR from the amp-taboola PR to allow separate discussions.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ampsauce
Copy link

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: fc8515d
Build details: https://travis-ci.org/ampsauce/amphtml/builds/103981120

(Please note that this is a fully automated comment.)

@nitzanvolman
Copy link
Contributor Author

the functionality here is covered in #1607, making this PR obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants