✅ 🐛 Don't load the karma-coverage plugin by default #14682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Apr 17, 2018
|
Can't log into GitHub on my phone, so replying via email. LGTM.
…On Tue, Apr 17, 2018, 6:30 PM Justin Ridgewell ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14682 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACV2B-mUCdWJVTS3AWtH46FV8OcVgSapks5tpmz5gaJpZM4TZJHQ>
.
|
jonkeller
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing
karmadisconnects on Travis whenever our tests use sauce labs. See https://travis-ci.org/ampproject/amphtml/jobs/367837186#L728-L740It's possible that this could be due to the use of code coverage plugins. See karma-runner/karma-sauce-launcher#95 (comment)
This PR lazily loads the
karma-coverageplugin only if the--coverageflag is used. Hopefully, this will reduce the number of disconnects on Travis.