🌐Use moment-with-locales to fix date-picker locale support #14348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
approved these changes
Apr 3, 2018
|
LGTM. Curious about why we're including a compiled bundle in the repo? |
|
There's precedent for bundles for third party dependencies that don't change often. See https://github.com/ampproject/amphtml/blob/master/third_party/caja for one example |
This was referenced Mar 31, 2021
This was referenced Apr 12, 2021
This was referenced Apr 27, 2021
This was referenced Sep 15, 2021
This was referenced Dec 15, 2021
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14044
This keeps locale support but increases the size of the requirements bundle a lot. I will hope to fix the dependency size without changing any API before amp-date-picker leaves doc-level optin.