amp-carousel : images load intermittently #27036

anuragphadke · 2020-02-29T20:33:21Z

What's the issue?

I am using amp-carousel-0.2.js, however, images in the tag fail to load 1/5 attempts.

How do we reproduce the issue?

Visit: https://beta.webfast.co/amp/image-carousel.html
Press cmd-shift-r (hard refresh) and you will notice that the image in the carousel only loads intermittently.

Another way to produce, start Chrome on iOS in incognito mode:

Visit: https://beta.webfast.co/amp/image-carousel.html, images don't load at first try.
reload the page.
images will now load.
The above is repeatable everytime u close all incognito windows on Chrome on iOS.

What browsers are affected?

All browsers on mobile.

Which AMP version is affected?

AMP version: 2002192257490
AMP carousel: https://cdn.ampproject.org/v0/amp-carousel-0.2.js

Is this a new issue? Or was it always broken? Paste the version of AMP where you saw this issue.
Experiencing for first time related to the above page.

anuragphadke · 2020-03-03T15:08:55Z

@alanorozco : any possible workarounds that I can use until this gets fixed?

rsmith4321 · 2020-03-05T06:08:47Z

I seem to be having the exact same issue. I'm very consistently getting missing images in the carousel. After scrolling through the entire gallery using the loop attribute and repeating the image will appear. This doesn't happen with v0.1. It seems to happen randomly I think it's an image lazyloading issue. Watching the network tab in chrome I see the image load, but it's blank in the carousel. Also I thought this was a Chrome issue only, but I've seen it happen once on iOS as well when opening a private tab. I'm going to switch back to v0.1 for now, but if anyone wants to test this live I can make a test page.

rsmith4321 · 2020-03-16T02:41:52Z

I'm done some more testing on this issue. It seems to be related to the amp-carousel that is generated by Jetpack. Can someone do some testing with amp-carousel v2 and the jetpack gallery? I've switched to using the code generated from a standard wordpress gallery and just adding the loop and autoplay attributes to get the same functionality as the Jetpack gallery. Adding the code manually I no longer get missing images in the slideshow.

westonruter · 2020-09-17T00:57:56Z

I can reliably regularly (if yet sporadically) reproduce this issue on: https://www.ryansmithphotography.com/

Here's a screen capture showing the problem after several reload attempts: https://youtu.be/nBtjBtai8s0

This may be a similar issue to #26952.

@jridgewell @choumx Is this Resources bug? Will it be fixed by IntersectionObserver?

rsmith4321 · 2020-09-17T01:47:42Z

Thanks for checking this issue. Like I mentioned I've never seen this issue when adding the amp-carousel in directly with code in an html block. So I don't know if there is something different with the way the block is loaded with jetpack.

…

On Wed, Sep 16, 2020, 8:58 PM Weston Ruter ***@***.***> wrote: I can reliably regularly (if yet sporadically) reproduce this issue: https://www.ryansmithphotography.com/ Here's a screen capture showing the problem after several reload attempts: https://youtu.be/nBtjBtai8s0 This may be a similar issue to #26952 <#26952>. @jridgewell <https://github.com/jridgewell> @choumx <https://github.com/choumx> Is this Resources bug? Will it be fixed by IntersectionObserver? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#27036 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2Y5H7MZ5HCXX573OBGIFTSGFNKHANCNFSM4K66A5SQ> .

jridgewell · 2020-09-21T20:18:29Z

Hi @rsmith4321, thanks for the report!

After investigating, I'm convinced this is caused by a bug in newly launched experiment. The bug fix was merged in #30188, and will rollout to production tomorrow.

rsmith4321 · 2020-09-24T13:11:55Z

I'm still able to recreate the issue by doing an empty cache reload. I've also noticed this issue for many months when I use the jetpack carousel so I don't think it's anything recent. I've never seen the issue adding an amp-carousel in an html block. Thanks.
https://drive.google.com/file/d/1Fr7InOAbm5Ut_BLqZhLcEfpNB25ql7mg/view?usp=sharing

jridgewell · 2020-09-28T20:57:16Z

Wow, this is strange. The amp-img failed to upgrade to the AmpImg BaseElement. We're still using the ElementStub. In fact, it's already "laid out":

Reopening, setting to a higher priority. /cc @dvoytenko

When an unlayout (eg, when carousel swipes away) occurs before an unlayout, we can get into a broken state where we _think_ we're fully laid out but in reality we've performed the unlayout. There's still race conditions in each component, since they need to track their own layout/unlayout state. We should quickly migrate to Bento where this isn't an issue. Fixes ampproject#27036 Partial ampproject#13838

* Fix race condition with layout -> unlayout When an unlayout (eg, when carousel swipes away) occurs before an unlayout, we can get into a broken state where we _think_ we're fully laid out but in reality we've performed the unlayout. There's still race conditions in each component, since they need to track their own layout/unlayout state. We should quickly migrate to Bento where this isn't an issue. Fixes #27036 Partial #13838 * Rename variable * Throw cancellation errors where appropriate * Review fixes * Fix dep requirement * Fix sourcemap check * Fix tests * Only allow missing signal param in test mode * Do not report missing abortController Since we're clearing it out after layout completes, it won't exist when we eventually unlayout * Toggle amp-analytics visibility _after_ layout * Fix method call * Fix test * lint * Fix test

rsmith4321 · 2020-10-12T03:07:54Z

Is there is way to know when this update will be live? Do we have to wait for a version 0.3 of the amp-carousel? Thanks!

jridgewell · 2020-10-12T22:30:02Z

It will be live in beta (1% of users) tomorrow afternoon, and production (100%) next Tuesday.

* Fix race condition with layout -> unlayout When an unlayout (eg, when carousel swipes away) occurs before an unlayout, we can get into a broken state where we _think_ we're fully laid out but in reality we've performed the unlayout. There's still race conditions in each component, since they need to track their own layout/unlayout state. We should quickly migrate to Bento where this isn't an issue. Fixes ampproject#27036 Partial ampproject#13838 * Rename variable * Throw cancellation errors where appropriate * Review fixes * Fix dep requirement * Fix sourcemap check * Fix tests * Only allow missing signal param in test mode * Do not report missing abortController Since we're clearing it out after layout completes, it won't exist when we eventually unlayout * Toggle amp-analytics visibility _after_ layout * Fix method call * Fix test * lint * Fix test

anuragphadke added the Type: Bug label Feb 29, 2020

wassgha added P2: Soon Component: amp-base-carousel WG: components labels Mar 2, 2020

wassgha assigned alanorozco Mar 2, 2020

westonruter mentioned this issue Mar 5, 2020

Add attributes in amp-carousel ampproject/amp-wp#4361

Closed

westonruter mentioned this issue Sep 14, 2020

Missing images in amp-carousel added by jetpack ampproject/amp-wp#5377

Closed

jridgewell closed this as completed Sep 21, 2020

samouri mentioned this issue Sep 21, 2020

🌸 Cherry-pick request for #30188,#30167 into #30086 (Pending) #30320

Closed

jridgewell reopened this Sep 28, 2020

jridgewell added P1: High Priority and removed P2: Soon labels Sep 28, 2020

jridgewell assigned jridgewell and unassigned alanorozco Sep 28, 2020

jridgewell added the WG: runtime label Sep 28, 2020

jridgewell mentioned this issue Sep 29, 2020

🐛 Fix race condition with layout -> unlayout #30426

Merged

jridgewell closed this as completed in #30426 Oct 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

amp-carousel : images load intermittently #27036

amp-carousel : images load intermittently #27036

anuragphadke commented Feb 29, 2020 •

edited

Loading

anuragphadke commented Mar 3, 2020

rsmith4321 commented Mar 5, 2020 •

edited

Loading

rsmith4321 commented Mar 16, 2020

westonruter commented Sep 17, 2020 •

edited

Loading

rsmith4321 commented Sep 17, 2020 via email

jridgewell commented Sep 21, 2020

rsmith4321 commented Sep 24, 2020

jridgewell commented Sep 28, 2020 •

edited

Loading

rsmith4321 commented Oct 12, 2020 •

edited

Loading

jridgewell commented Oct 12, 2020

amp-carousel : images load intermittently #27036

amp-carousel : images load intermittently #27036

Comments

anuragphadke commented Feb 29, 2020 • edited Loading

What's the issue?

How do we reproduce the issue?

What browsers are affected?

Which AMP version is affected?

anuragphadke commented Mar 3, 2020

rsmith4321 commented Mar 5, 2020 • edited Loading

rsmith4321 commented Mar 16, 2020

westonruter commented Sep 17, 2020 • edited Loading

rsmith4321 commented Sep 17, 2020 via email

jridgewell commented Sep 21, 2020

rsmith4321 commented Sep 24, 2020

jridgewell commented Sep 28, 2020 • edited Loading

rsmith4321 commented Oct 12, 2020 • edited Loading

jridgewell commented Oct 12, 2020

anuragphadke commented Feb 29, 2020 •

edited

Loading

rsmith4321 commented Mar 5, 2020 •

edited

Loading

westonruter commented Sep 17, 2020 •

edited

Loading

jridgewell commented Sep 28, 2020 •

edited

Loading

rsmith4321 commented Oct 12, 2020 •

edited

Loading