Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create meta tag for allowing local http sites during testing only #1252

Closed
ccstartfish101 opened this issue Dec 28, 2015 · 10 comments
Closed

Comments

@ccstartfish101
Copy link

Allowing whitelisting local http sites is very convenient for testing. We should create a meta tag that itself is invalid AMP and thus cannot be deployed to production.

@dvoytenko
Copy link
Contributor

Should we just do it under development=1?

@cramforce
Copy link
Member

That doesn't help security wise because it is subject to downgrade attack.
I think allowing it only if the meta tag is present and the AMP itself is
on HTTP is OK.
On Dec 28, 2015 10:38 AM, "Dima Voytenko" [email protected] wrote:

Should we just do it under development=1?


Reply to this email directly or view it on GitHub
#1252 (comment)
.

@ericlindley-g ericlindley-g added this to the M2 milestone Feb 5, 2016
@rudygalfi rudygalfi modified the milestones: M2, Backlog Mar 4, 2016
@src-code
Copy link
Contributor

src-code commented Mar 9, 2016

I'd like to see something like this implemented soon - right now testing pre-production environments other than localhost that aren't terminating https is rather difficult, especially when substitutions like SOURCE_HOST aren't returning the port number (I'm planning to submit a pull for that one...)

@adelinamart
Copy link
Contributor

Do we still need this? Thanks

@src-code
Copy link
Contributor

src-code commented Feb 7, 2017

@adelinamart I think so. The substitutions I referenced above don't really help, since they're encoded and thus can't be used when setting the host portion of a url.

@adelinamart adelinamart modified the milestones: New FRs, Pending Triage Feb 7, 2017
@dvoytenko
Copy link
Contributor

I agree. This would be very helpful.

@adelinamart
Copy link
Contributor

@dvoytenko are we planning to prioritize this anytime soon?Thanks

@dvoytenko
Copy link
Contributor

This sounds useful, but I still see it as a p3.

@Gregable
Copy link
Member

Is this still useful? (I think yes).

What are we whitelisting when this meta tag is present? (I think: allowing relative URLs in the validator in the handful of places where relative URLs are disallowed. Anything else?)

@honeybadgerdontcare
Copy link
Contributor

#16616 introduces the ability to turn off validation with #validate=0 on the query string when in developer mode. If that doesn't fully address this issue, then please reopen with why it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants