Collapse empty ads in situation where iframe resizing is allowed

[cramforce]

If we are allowed to resize the iframe of the ad and there is no ad to serve, remove the ad from the page.

CC @kashyapnitin

[ds0001]

👍

[camelburrito]

Does this need animation?

[cramforce]

No.
On Dec 29, 2015 12:02 PM, "Sriram Krishnan" [email protected]
wrote:

Does this need animation?

—
Reply to this email directly or view it on GitHub
#1089 (comment)
.

[camelburrito]

@cramforce We only collapse if there is no placeholder right?

[cramforce]

Right

[camelburrito]

@cramforce we dont support resizing on amp-ad iframes yet, should I implement resizing support as well?

[cramforce]

Yes, but sync with Dima. He might have a pending CL. Doing this special
case is a good first step, though.
On Dec 29, 2015 1:23 PM, "Sriram Krishnan" [email protected] wrote:

@cramforce https://github.com/cramforce we dont support resizing on
amp-ad iframes yet, should I implement resizing support as well?

—
Reply to this email directly or view it on GitHub
#1089 (comment)
.

[camelburrito]

adding @dvoytenko to the conversation

[dvoytenko]

Yeah, let's roll it in this PR. Most of the implementation is already done in the custom-element.js - which just need to trigger it.