Skip to content

Commit

Permalink
Add JS comment
Browse files Browse the repository at this point in the history
Add JS comment to explain why there is no good way to do `noContentAvailable` call.
  • Loading branch information
PengXing authored Dec 4, 2018
1 parent ef71a8b commit da772ce
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ads/baidu.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ export function baidu(global, data) {
'https://dup.baidustatic.com/js/dm.js',
() => {},
() => {
// noContentAvailable should be called if parent iframe receives no message.
// setTimeout can work, but it's not that reliable.
// So, only the faliure of JS loading is dealed with for now.
global.context.noContentAvailable();
}
);
Expand Down

0 comments on commit da772ce

Please sign in to comment.