Requested change

ampproject · Aug 17, 2017 · a84a879 · a84a879
1 parent c3f5ee3
commit a84a879
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/event-helper-listen.js b/src/event-helper-listen.js
@@ -82,7 +82,7 @@
  */
  export function detectEvtListenerOptsSupport() {
    // Only run the test once
-   if (typeof optsSupported != 'undefined') {
+   if (optsSupported !== undefined) {
      return optsSupported;
    }
 
@@ -95,6 +95,7 @@
        },
      };
      self.addEventListener('test-opts', null, options);
+     self.removeEventListener('test-opts', null, options);
    } catch (err) {
      // EventListenerOptions are not supported
    }
@@ -104,6 +105,6 @@
  /**
   * Resets the test for whether addEventListener supports options or not.
   */
- export function resetEvtListenerOptsSupport() {
+ export function resetEvtListenerOptsSupportForTesting() {
    optsSupported = undefined;
  }
diff --git a/test/functional/test-event-helper.js b/test/functional/test-event-helper.js
@@ -24,7 +24,7 @@ import {
 } from '../../src/event-helper';
 import {
   detectEvtListenerOptsSupport,
-  resetEvtListenerOptsSupport,
+  resetEvtListenerOptsSupportForTesting,
 } from '../../src/event-helper-listen';
 import {Observable} from '../../src/observable';
 import * as sinon from 'sinon';
@@ -260,14 +260,14 @@ describe('EventHelper', () => {
           }
         }
     );
-    resetEvtListenerOptsSupport();
+    resetEvtListenerOptsSupportForTesting();
     expect(detectEvtListenerOptsSupport()).to.be.true;
     expect(addEventListenerStub.called).to.be.true;
-    resetEvtListenerOptsSupport();
+    resetEvtListenerOptsSupportForTesting();
   });
 
   it('should cache the result of the test and only do it once', () => {
-    resetEvtListenerOptsSupport();
+    resetEvtListenerOptsSupportForTesting();
     expect(detectEvtListenerOptsSupport()).to.be.true;
     expect(addEventListenerStub.called).to.be.true;
     expect(detectEvtListenerOptsSupport()).to.be.true;
@@ -284,7 +284,7 @@ describe('EventHelper', () => {
           }
         }
     );
-    resetEvtListenerOptsSupport();
+    resetEvtListenerOptsSupportForTesting();
     expect(detectEvtListenerOptsSupport()).to.be.false;
     expect(addEventListenerStub.called).to.be.true;
     expect(detectEvtListenerOptsSupport()).to.be.false;