Skip to content

Commit

Permalink
amp-embed now validates.
Browse files Browse the repository at this point in the history
  • Loading branch information
cramforce committed Jan 30, 2016
1 parent e587ef4 commit 06d4b72
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
1 change: 0 additions & 1 deletion test/integration/test-example-validation.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ describe('example', function() {
*/
const errorWhitelist = [
/invalid value \'.\/viewer-integr.js\'/,
/amp-embed/
];

const usedWhitelist = [];
Expand Down
9 changes: 4 additions & 5 deletions test/integration/test-released.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,9 @@ function runTest(shouldKillPolyfillableApis) {
if (shouldKillPolyfillableApis) {
win.Promise = undefined;
}
})
.then(f => {
fixture = f;
});
}).then(f => {
fixture = f;
});
});

// There is really weird behavior when running this test in FF in
Expand Down Expand Up @@ -74,7 +73,7 @@ function checkGlobalScope(win) {
// Checks that we don't leak certain symbols to the global scope.
// This could happen if we do not wrap all our code in a closure.
const commonSymbols = [
'$', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'x', 'z', '_', 'log'];
'$', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'x', 'z', '_', 'log'];
expect(win).to.not.include.keys(commonSymbols);
expect(win).to.not.include.keys(commonSymbols.map(symbol => {
return symbol.toUpperCase();
Expand Down

0 comments on commit 06d4b72

Please sign in to comment.