Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of response when it is not HTML #947

Merged
merged 2 commits into from
Feb 9, 2018
Merged

Fix handling of response when it is not HTML #947

merged 2 commits into from
Feb 9, 2018

Conversation

westonruter
Copy link
Member

Amends #923.

Fixes issue where a POST form submission, such as with a Jetpack contact form, results in:

  • Output buffered response is getting erroneously parsed as DOMDocument when it not HTML at all, e.g. JSON or an empty doc such as for redirect.
  • 500 internal error in the style sanitizer when there is no head element.

@westonruter westonruter added this to the v0.7 milestone Feb 9, 2018
@westonruter westonruter requested a review from ThierryA February 9, 2018 07:23
@ThierryA ThierryA merged commit b8d9a2c into develop Feb 9, 2018
@westonruter westonruter deleted the fix/handling-response-for-non-html branch February 9, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThierryA ThierryA ThierryA approved these changes

@DavidCramer DavidCramer Awaiting requested review from DavidCramer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @ThierryA @DavidCramer