-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve PHP 8.4 compatibility #7897
Conversation
Regarding the PHPStan issues, see also #7876. |
@thelovekesh Could you address the remaining PHPStan issues? |
As part of this, we should also update PHP-CSS-Parser which was just updated to improve PHP 8.4 compatibility: https://github.com/MyIntervals/PHP-CSS-Parser/releases/tag/v8.7.0 |
Might be a bigger change that warrants its own PR, as I assume the package‘s namespace changed as well and all those parches don‘t apply anymore |
The remaining error is due to a change in PHP 8.4 for the string representation of a closure. Should be a trivial fix. |
I'll defer that to you then 😃 |
daf638b
to
45ff83b
Compare
45ff83b
to
5fda4ab
Compare
Oof. That was more of a headache than I was expecting! Really confused why I needed to do d1e4a50 now just for PHP 8.4 although it also is failing for me locally in PHP 8.3. It should have been failing for all PHP versions. |
Summary
This addresses all deprecation warnings on PHP 8.4, unblocking PHP 8.4 compatibility in the Web Stories plugin.
The handful of PHPStan failures are unrelated and can be addressed separately.
There are some test failures too but they can be handled separately as well.
Checklist