Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHP 8.4 compatibility #7897

Merged
merged 16 commits into from
Nov 4, 2024
Merged

Improve PHP 8.4 compatibility #7897

merged 16 commits into from
Nov 4, 2024

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Oct 18, 2024

Summary

This addresses all deprecation warnings on PHP 8.4, unblocking PHP 8.4 compatibility in the Web Stories plugin.

The handful of PHPStan failures are unrelated and can be addressed separately.

There are some test failures too but they can be handled separately as well.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@swissspidy swissspidy added the Enhancement New feature or improvement of an existing one label Oct 18, 2024
@swissspidy swissspidy marked this pull request as ready for review October 18, 2024 12:06
@westonruter
Copy link
Member

Regarding the PHPStan issues, see also #7876.

@westonruter
Copy link
Member

@thelovekesh Could you address the remaining PHPStan issues?

@westonruter
Copy link
Member

As part of this, we should also update PHP-CSS-Parser which was just updated to improve PHP 8.4 compatibility: https://github.com/MyIntervals/PHP-CSS-Parser/releases/tag/v8.7.0

@swissspidy
Copy link
Collaborator Author

Might be a bigger change that warrants its own PR, as I assume the package‘s namespace changed as well and all those parches don‘t apply anymore

@westonruter
Copy link
Member

The remaining error is due to a change in PHP 8.4 for the string representation of a closure. Should be a trivial fix.

@swissspidy
Copy link
Collaborator Author

I'll defer that to you then 😃

@westonruter westonruter self-assigned this Nov 4, 2024
@westonruter westonruter added this to the v2.5.5 milestone Nov 4, 2024
@westonruter
Copy link
Member

Oof. That was more of a headache than I was expecting! Really confused why I needed to do d1e4a50 now just for PHP 8.4 although it also is failing for me locally in PHP 8.3. It should have been failing for all PHP versions.

@westonruter westonruter merged commit 7b016fa into develop Nov 4, 2024
32 of 33 checks passed
@westonruter westonruter deleted the fix/php84 branch November 4, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants