Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate runtime precaching of AMP scripts in Service Worker #7895

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Eliminate runtime precaching of AMP scripts in Service Worker #7895

merged 5 commits into from
Nov 12, 2024

Conversation

westonruter
Copy link
Member

Fixes #7882

@westonruter westonruter added the Bug Something isn't working label Oct 7, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@westonruter westonruter added this to the v2.5.5 milestone Nov 11, 2024
@westonruter
Copy link
Member Author

Actually, we need to get rid of the amp-server-worker-runtime-precaching altogether because when serving Optimized AMP, the .mjs versions of the scripts are being served and not the .js ones. But we were precaching the .js files:

image

But these .js files aren't even used. So that's wasted download.

@westonruter
Copy link
Member Author

Now with the changes in this PR, only the .mjs scripts are added to the runtime cache and nothing is precached:

image

@westonruter westonruter changed the title Only add AMP scripts to runtime cache in Standard Mode Eliminate runtime precaching of AMP scripts in Service Worker Nov 12, 2024
@westonruter westonruter merged commit e9b7e61 into develop Nov 12, 2024
34 of 35 checks passed
@westonruter westonruter deleted the fix/pwa-runtime-cache branch November 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelovekesh thelovekesh thelovekesh approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
v2.5.5
Development

Successfully merging this pull request may close these issues.

AMP scripts are added to runtime cache even if an AMP page is never accessed
2 participants
@westonruter @thelovekesh