Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.1/8.2 deprecation warnings #7451

Closed

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Feb 6, 2023

Summary

Update AMP_HTTP::send_header() to pass the third param as int in header() which was causing this deprecation warning:

PHP Deprecated:  header(): Passing null to parameter #3 ($response_code) of type int is deprecated in C:\Users\win 10\Local Sites\php8amp\app\public\wp-content\plugins\amp\includes\class-amp-http.php on line 95

Fixes #

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh self-assigned this Feb 6, 2023
@thelovekesh thelovekesh added this to the v2.4 milestone Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Plugin builds for aebbeda are ready 🛎️!

@thelovekesh
Copy link
Collaborator Author

Closing in the favor of #7452

@thelovekesh thelovekesh closed this Feb 6, 2023
@thelovekesh thelovekesh deleted the fix/php-8.1-and-8.2-deprecation-warnings branch February 6, 2023 20:30
@thelovekesh thelovekesh removed this from the v2.4 milestone Feb 6, 2023
@thelovekesh thelovekesh removed their assignment Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant